-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lucide package for Astro #2665
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const PictureInPictureIcon = createLucideIcon('PictureInPicture', [
["path",{"d":"M2 10h6V4"}],
["path",{"d":"m2 4 6 6"}],
["path",{"d":"M21 10V7a2 2 0 0 0-2-2h-7"}],
["path",{"d":"M3 14v2a2 2 0 0 0 2 2h3"}],
["rect",{"width":"10","height":"7","x":"12","y":"14","rx":"1"}]
]) |
The PR is ready to be reviewed Here's the demo project using both the legacy and rewritten package https://stackblitz.com/github/MoustaphaDev/lucide-astro-next-demo Here are the differences between the legacy package and the new package:
---
import * as icons from "lucide-astro" // ❌ wrong way, `icons` will contain symbols other than icon components
import { icons } from "lucide-astro" // ✅ right way, `icons` only contains icon components
---
|
8483f9a
to
77fa995
Compare
This looks epic, hope you're pleased with how it turned out! |
…nto feat/astro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @MoustaphaDev!
We are almost good to go!
If @Aviortheking also approves this PR and is ready to transfer the ownership of the NPM package we can start publishing!
@@ -0,0 +1,29 @@ | |||
import { parseHTML } from 'linkedom'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 😎
I'll take a look later in the week :D |
TODOs:
What is the purpose of this pull request?
Description
Add a new package for first-class Astro support.
Here's the demo project using both the legacy and rewritten package: demo project
See #2665 (comment) for more details.
Before Submitting