Update lucide-svelte for compatibility with Svelte 5 runes mode #2727
+1,368
−555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update peerDependencies to support Svelte 5 * Bump svelte version * Bump @testing-library/svelte version * Remove alias in vitest.config.ts that causes tests to fail due to deprecated svelte/internal API * Convert to svelte 5 syntax * Bump vite & @sveltejs/vite-plugin-svelte version * Fix error during render when children prop is missing & fix components being mounted on the server during tests * Update test snapshots to reflect the differences in the html generated by svelte 5 * Convert class attribute to new array syntax with built-in clsx * Convert export template to svelte 5 syntax
github-actions
bot
added
📦 dependencies
aurelienrichard
changed the title
aurelienrichard
changed the title
|
Nice work @aurelienrichard! I'm not a maintainer but just gave the diff a look over looks like you caught everything. Hopefully this gets a merge soon. |
|
@karsa-mistmere Sorry for the Ping, but this would be so important for me and many others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2312
closes #2565
closes #2716
What is the purpose of this pull request?
Description
Adds Svelte 5 runes mode compatibility to
lucide-sveltepackage.This involved updating the following dependencies:
@sveltejs/vite-plugin-svelte,@testing-library/svelte,svelte,vitepnpm-lock.yamlis updated to reflect the above.The following files have been updated with the new Svelte 5 runes syntax and types:
Icon.svelteexportTemplate.mjstypes.tsThis includes support for the new built-in class syntax.
The test snapshots had to be updated for the tests to pass. This is because the HTML generated by Svelte 5 is slightly different from that generated by Svelte 4.
vitest.config.ts:Updated to reflect the version bump of the svelte plugin (
hot: falseis now deprecated).Running the tests was throwing an error about
onMountbeing called on the server. Following these steps from the testing library docs fixed it.There is a type error that I couldn't seem to solve so it's under
@ts-expect-errorfor now.Before Submitting