[PE-239] chore: add strictNullCheck flag to the editor package

[aaryan610]

Description

This PR adds the strictNullCheck flag to the editor package tsconfig for better error handling.

Type of Change

• Improvement (change that would cause existing functionality to not work as expected)

Summary by CodeRabbit

• Chores
  • Enhanced TypeScript type safety by enabling strict null checks in the project configuration.

[coderabbitai]

Walkthrough

This pull request modifies the packages/editor/tsconfig.json configuration by introducing the "strictNullChecks": true compiler option. This TypeScript compiler setting enhances type checking by enforcing more rigorous handling of null and undefined values, which can help prevent potential null-related errors during compilation and improve overall type safety in the project.

Changes

File	Change Summary
packages/editor/tsconfig.json	Added "strictNullChecks": true compiler option

Possibly related PRs

• [WEB-2424] fix: add optional chaining for parent node #5571: Introduces nullish coalescing checks to handle potential null or undefined values
• [PE-228] fix: update tiptap package versions #6361: Updates the @tiptap/html package, which may interact with TypeScript type checking
• [PE-228] chore: update @tiptap/extension-task-item version and required css #6364: Updates the version of @tiptap/extension-task-item

Suggested labels

🌟improvement, 🛠️refactor

Suggested reviewers

• rahulramesha

Poem

🐰 Null checks hopping with glee,
Strict typing, now we can see!
No more sneaky undefined fears,
TypeScript's magic now appears!
Compiler's wisdom, sharp and bright! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/editor/tsconfig.json (1)

15-15: Consider enabling full strict mode.

While strictNullChecks is a good start, consider enabling the full strict flag to catch more potential issues. This would enable additional checks like strictFunctionTypes, strictBindCallApply, etc.

You could enhance type safety further with:

 {
   "compilerOptions": {
+    "strict": true,
-    "strictNullChecks": true,
     ...
   }
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58a4b45 and 6a1d99f.

📒 Files selected for processing (1)

• packages/editor/tsconfig.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

packages/editor/tsconfig.json (1)

15-15: LGTM! But let's verify the impact.

Adding strictNullChecks is a good step towards better type safety. However, this change might surface existing null-handling issues in the codebase.

Let's check for potential null-handling issues that might need fixing:

✅ Verification successful

Enabling strictNullChecks is safe to proceed with.

The codebase already follows strict null-checking patterns with extensive use of optional chaining, explicit null guards, and proper null-state handling throughout the editor components.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Look for patterns that might need attention with strictNullChecks

# Search for non-null assertions that might need proper null checks
echo "Checking for non-null assertions (!.) that might need proper null checks..."
rg "!." packages/editor/src

# Search for potential null access without checks
echo "Checking for potential null access patterns..."
ast-grep --pattern 'const $x = $y.$z' packages/editor/src

# Look for optional chaining that might indicate existing null-awareness
echo "Checking existing null-aware code..."
rg "\?\." packages/editor/src

Length of output: 53415