simplify language configuration #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
approved these changes
Nov 9, 2023
Arker123
reviewed
Nov 9, 2023
Comment on lines
+551
to
+560
| if args.language == Language.GO.value: | ||
| lang_id = Language.GO | ||
| elif args.language == Language.RUST.value: | ||
| lang_id = Language.RUST | ||
| elif args.language == Language.DOTNET.value: | ||
| lang_id = Language.DOTNET | ||
| elif args.language == "none": | ||
| lang_id = Language.UNKNOWN | ||
| else: | ||
| lang_id = identify_language(sample, static_strings) |
There was a problem hiding this comment.
Suggested change
| if args.language == Language.GO.value: | |
| lang_id = Language.GO | |
| elif args.language == Language.RUST.value: | |
| lang_id = Language.RUST | |
| elif args.language == Language.DOTNET.value: | |
| lang_id = Language.DOTNET | |
| elif args.language == "none": | |
| lang_id = Language.UNKNOWN | |
| else: | |
| lang_id = identify_language(sample, static_strings) | |
| lang_id_mapping = { | |
| Language.GO.value: Language.GO, | |
| Language.RUST.value: Language.RUST, | |
| Language.DOTNET.value: Language.DOTNET, | |
| "none": Language.UNKNOWN, | |
| } | |
| lang_id = lang_id_mapping.get(args.language, identify_language(sample, static_strings)) |
I suggest adopting this mapping approach for language identification. What do you think?
There was a problem hiding this comment.
that's neat, please submit a PR as this is already merged now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.