Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Update docs for Select, MultiSelect, Autocomplete to warn about data props consisting of unique values #7181

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[@mantine/core] Update docs for Select, MultiSelect, Autocomplete to warn about data props consisting of unique values #7181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@mantine/core/src/components/Autocomplete/Autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface AutocompleteProps
Omit<ComboboxLikeProps, 'data'>,
StylesApiProps<AutocompleteFactory>,
ElementProps<'input', 'onChange' | 'size'> {
/** Data displayed in the dropdown */
/** Data displayed in the dropdown. Values must be unique, otherwise an error will be thrown and component will not render. */
data?: ComboboxStringData;

/** Controlled component value */
Expand Down
2 changes: 1 addition & 1 deletion packages/@mantine/core/src/components/Combobox/Combobox.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export type ComboboxParsedItem = ComboboxItem | ComboboxParsedItemGroup;
export type ComboboxLikeStylesNames = Exclude<ComboboxStylesNames, 'header' | 'footer' | 'search'>;

export interface ComboboxLikeProps {
/** Data used to generate options */
/** Data used to generate options. Values must be unique, otherwise an error will be thrown and component will not render. */
data?: ComboboxData;

/** Controlled dropdown opened state */
Expand Down
2 changes: 1 addition & 1 deletion packages/@mantine/core/src/components/TagsInput/TagsInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export interface TagsInputProps
Omit<ComboboxLikeProps, 'data'>,
StylesApiProps<TagsInputFactory>,
ElementProps<'input', 'size' | 'value' | 'defaultValue' | 'onChange'> {
/** Data displayed in the dropdown */
/** Data displayed in the dropdown. Values must be unique, otherwise an error will be thrown and component will not render. */
data?: ComboboxStringData;

/** Controlled component value */
Expand Down