Opt into Ruby frozen string literals throughout the codebase #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
added
the
automerge
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 22, 2024
When running `tomo deploy` in a multi-environment project with no environment explicitly specified, tomo prompts: ``` Choose an environment: ❯ staging production ``` Interacting with this menu with the keyboard would result in an error: ``` forwardable.rb:240:in 'String#clear': can't modify frozen String: "" (FrozenError) from forwardable.rb:240:in 'Tomo::Console::KeyReader#clear' ``` This is because the internal `buffer` used by `KeyReader` was frozen as a side effect of #446. Fix by marking `buffer` as mutable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
# frozen_string_literal: truecomment to all of tomo's Ruby files.This prepares tomo for a future version of Ruby (4?), where string literals will likely become frozen by default.