feature view engine patches #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The adagios.status.initilize_multiselect_checkboxes is already run within adagios_status.js and is not needed and is failing.
…adagios into matthieucan-feature-view-engine
This patch fixes an issue where custom_view cannot be loaded because an extra linebreak is sent with the livestatus query. I am guessing shinken's implementation of livestatus does not care about this.
If livestatus queries fail, return 500 error This should make unit testing of the view easier.
|
Alright, done here opinkerfi#383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor patches i needed to do before getting custom view up and running on my machine
I havent done a pull request on top of pull request before. Hope this works out :)