Skip to content

Commit

Permalink
Merge #568
Browse files Browse the repository at this point in the history
568: Add Embedder.URL r=brunoocasali a=polyfloyd

# Pull Request

## What does this PR do?
Partial fix for #576

The documentation for the Ollama Embedder states that there is an `url` field that can be used to specify how Ollama can be reached. However, this field is not present yet in this client library.

See: https://www.meilisearch.com/docs/learn/experimental/vector_search#generate-auto-embeddings

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: polyfloyd <[email protected]>
  • Loading branch information
meili-bors[bot] and polyfloyd authored Sep 15, 2024
2 parents 345439c + 9ffd104 commit e09d86e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions types.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ type Faceting struct {

type Embedder struct {
Source string `json:"source"`
URL string `json:"url,omitempty"`
ApiKey string `json:"apiKey,omitempty"`
Model string `json:"model,omitempty"`
Dimensions int `json:"dimensions,omitempty"`
Expand Down
7 changes: 7 additions & 0 deletions types_easyjson.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e09d86e

Please sign in to comment.