Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: switch build/tsconfig.json to module: nodenext #238426

Merged
merged 3 commits into from
Jan 22, 2025
Merged

build: switch build/tsconfig.json to module: nodenext #238426

merged 3 commits into from
Jan 22, 2025

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Jan 22, 2025

This makes the ./build generated js code compatible with bun

Using bun instead of node results in faster compiles:

$ npm run watch
Finished compilation with 0 errors after 49305 ms

$ bun run -b watch
Finished compilation with 0 errors after 37214 ms

cc @jrieken @deepak1556

@tmm1 tmm1 changed the title build: switch build/tsconfig to module: nodenext build: switch build/tsconfig.json to module: nodenext Jan 22, 2025
@deepak1556 deepak1556 assigned joaomoreno and unassigned deepak1556 Jan 22, 2025
@joaomoreno
Copy link
Member

This is great, thanks @tmm1!

@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Jan 22, 2025
@joaomoreno
Copy link
Member

joaomoreno commented Jan 22, 2025 •
edited
Loading

Looking forward to the leak fix in a future TypeScript version: microsoft/TypeScript#58137

We'll also reach out to the TypeScript team and nudge them.

@bpasero bpasero requested a review from mjbvz January 22, 2025 11:24
bpasero
bpasero approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM but I would love @mjbvz input too, given he is working on changing the module resolution for our sources in #236640

@bpasero bpasero merged commit e76c50f into microsoft:main Jan 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjbvz mjbvz mjbvz approved these changes

@bpasero bpasero bpasero approved these changes

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
5 participants
@tmm1 @joaomoreno @bpasero @mjbvz @deepak1556