Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing angle brackets from the language configuration #245

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

racz16
Copy link
Contributor

@racz16 racz16 commented Mar 23, 2024

VS Code uses the brackets listed in the antlr.configuration.json file's brackets property to color the corresponding brackets with the same color. However, if it finds a closing bracket, without an opening one, it colors the bracket red. When we send a token to a channel, the angle bracket of -> becomes red. This is why I removed angle brackets from the language configuration.
Before:
before
After:
after

@mike-lischke
Copy link
Owner

mike-lischke commented Mar 24, 2024

This depends also on the theme. The main problem is that the arrow and other syntactic elements are not handled by most themes, which is why I added one which does. That looks then so:

Bildschirmfoto 2024-03-24 um 11 13 12

but of course not everyone likes this.

To be able to merge I need the DCO check to pass. Please check that (follow the Details link)

@racz16
Copy link
Contributor Author

racz16 commented Mar 24, 2024

Yes, I think your theme is good, but people need to switch to it manually or they just don't want to use it. I fixed the commit.

@mike-lischke
Copy link
Owner

Please sign your commit if you want it to be merged.

@mike-lischke
Copy link
Owner

@racz16 Last chance to sign your PR.

@mike-lischke mike-lischke merged commit 67cdbe7 into mike-lischke:master Apr 20, 2024
3 checks passed
@mike-lischke
Copy link
Owner

Thanks!

@racz16 racz16 deleted the patch-1 branch April 20, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants