Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Maestro adapter #50

Closed
wants to merge 20 commits into from
Closed

feat: Maestro adapter #50

wants to merge 20 commits into from

Conversation

Vardominator
Copy link
Contributor

  • Abstracted Adapter interface
  • Added MaestroAdapter, which implements Adapter interface
  • Added example with MaestroAdapter
  • Various helpers
  • Various cleanup and formatting
  • Updated README
  • Updated tests

longngn
longngn requested changes Jan 3, 2025
View reviewed changes
src/utils/lucid.ts Outdated Show resolved Hide resolved
test/adapter.test.ts Outdated Show resolved Hide resolved
test/adapter.test.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
examples/blockfrost-adapter-example.ts Show resolved Hide resolved
@longngn longngn linked an issue Jan 3, 2025 that may be closed by this pull request
Use Provider architecture and integrate Maestro as a Provider #23
Open
longngn
longngn requested changes Jan 3, 2025
View reviewed changes
test/adapter.test.ts Outdated Show resolved Hide resolved
test/adapter.test.ts Outdated Show resolved Hide resolved
@Vardominator
Copy link
Contributor Author

@longngn thanks! I believe I have addressed everything but I don't understand the last comment.

@Vardominator Vardominator requested a review from longngn January 4, 2025 04:41
@Vardominator
Copy link
Contributor Author

@longngn done with everything

@longngn
Copy link
Member

longngn commented Jan 4, 2025

@longngn done with everything

I've added the Maestro API keys to run CI
however it has error when pnpm install now
can you update pnpm lock file (I think just need to run pnpm install again)

@Vardominator
Copy link
Contributor Author

@longngn done

@longngn
Copy link
Member

longngn commented Jan 6, 2025

@longngn done

it seems CI can't fetch secrets from PR that is based from a fork
i've added you as collaborator to this repo, can you re-create a PR directly in this repo to use CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longngn longngn Awaiting requested review from longngn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Provider architecture and integrate Maestro as a Provider
2 participants
@Vardominator @longngn