Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lang information on extension manager page #173

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

sub-versivo
Copy link
Contributor

I don't know many sources in the extension manager, and have to install it to check its language.
This commit adds the source language next to extension type, letting the user to know before installing it.

I don't know flutter very well, so, fell free to suggest improvements.

@sub-versivo
Copy link
Contributor Author

I can run the app locally, on android emulator, but the apk from CI don't installs.

Copy link
Member

@MiaoMint MiaoMint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MiaoMint
Copy link
Member

I can run the app locally, on android emulator, but the apk from CI don't installs.

I think it is caused by different signatures.

@MiaoMint MiaoMint merged commit 9b41e90 into miru-project:dev Jan 13, 2024
2 checks passed
appdevelpo pushed a commit that referenced this pull request Feb 7, 2024
* Add lang information on extension manager page

* Put language after extension type on Android

* upload

---------

Co-authored-by: MiaoMint <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants