upgrade node to v14 #5130
Merged
upgrade node to v14 #5130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5130 +/- ##
==========================================
- Coverage 93.94% 93.94% -0.01%
==========================================
Files 498 498
Lines 23121 23119 -2
Branches 1415 1415
==========================================
- Hits 21722 21720 -2
Misses 1294 1294
Partials 105 105
Continue to review full report at Codecov.
|
This upgrades nodejs to v14.18.2. This This isn't fully updated (current version is 17.x.x) but this will get us to the point where we can upgrade yarn to v3 and run some other upgrades that will then, I think, let us upgrade to a more recent nodejs version and so on. We're climbing the ladder here :) part of #5129 pr #5130
alicewriteswrongs
force-pushed
the
ap/upgrade-node-lint
branch
from
c063746 to
9f45e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
part of #5129
What's this PR do?
This upgrades our Node version to 14.18.2. This isn't fully updated (current version is 17.x.x) but this will get us to the point where we can upgrade yarn to v3 and run some other upgrades that will then, I think, let us upgrade to a more recent nodejs version and so on. We're climbing the ladder here :)
How should this be manually tested?
everything should work!