Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdjinterop 0.22.1, support for Engine 4.0.1 #13709

Merged
merged 1 commit into from
Oct 21, 2024
Merged

libdjinterop 0.22.1, support for Engine 4.0.1 #13709

merged 1 commit into from
Oct 21, 2024

Conversation

mr-smidge
Copy link
Contributor

@mr-smidge mr-smidge commented Sep 29, 2024 •
edited
Loading

Latest version of libdjinterop adds support for Engine 4.0.0/4.0.1.

Fixes #13695

Swiftb0y
Swiftb0y approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats needed for this packaging wise @daschuer?

@Swiftb0y
Copy link
Member

Thanks @mr-smidge for jumping on the issue this fast.

@JoergAtGithub
Copy link
Member

JoergAtGithub commented Sep 29, 2024 •
edited
Loading

I will provide the VCPKG port update needed for Windows!
microsoft/vcpkg#41251

@JoergAtGithub JoergAtGithub added this to the 2.4.2 milestone Sep 29, 2024
@mr-smidge
Copy link
Contributor Author

I'll do the libdjinterop PPA...

@mr-smidge
Copy link
Contributor Author

Ubuntu builds now all built and published 🚀.

@JoergAtGithub
Copy link
Member

mixxxdj/vcpkg#147
mixxxdj/vcpkg#148

@mr-smidge
Copy link
Contributor Author

What's left to do before this can be merged?

@Swiftb0y
Copy link
Member

Swiftb0y commented Oct 6, 2024

I think we need to bump the vcpkg version we use (to the updated one).

@JoergAtGithub
Copy link
Member

The new VCPKG 2.4 and 2.4-rel buildenvs are now ready at https://github.com/mixxxdj/vcpkg/branches
You need to apply the correct BUILDENV_NAMEs and BUILDENV_SHA256s now in this PR, similar as in: https://github.com/mixxxdj/mixxx/pull/13288/files

daschuer added a commit that referenced this pull request Oct 21, 2024
@daschuer
Merge pull request #13790 from JoergAtGithub/pr/13709
9e1efe2 
DjInterop PR #13709 with new VCPKG buildenv
@daschuer daschuer merged commit 2d52b76 into mixxxdj:2.4 Oct 21, 2024
13 of 14 checks passed
@JoergAtGithub
Copy link
Member

BTW: Engine 4.1 was published today. DigitalDjTips write about it: "the software uses an updated database, it’s not backwards compatible with 4.0 databases."

@mr-smidge
Copy link
Contributor Author

mr-smidge commented Oct 21, 2024 •
edited
Loading

BTW: Engine 4.1 was published today. DigitalDjTips write about it: "the software uses an updated database, it’s not backwards compatible with 4.0 databases."

Great timing! 😖

Have raised xsco/libdjinterop#129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
build library
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@mr-smidge @Swiftb0y @JoergAtGithub @daschuer