Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export getRequiredParams #160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

export getRequiredParams #160

wants to merge 1 commit into from

Conversation

berndbischl
Copy link
Member

@ja-thomas
do we still need this?

@coveralls
Copy link

coveralls commented Jan 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 96.005% when pulling df41802 on exportReqParNames into 82b8149 on master.

@ja-thomas
Copy link
Contributor

We wanted to use that in mlrMBO, but I think it's not necessary anymore

@berndbischl
Copy link
Member Author

ok i looked at this.
i still think this is useful and not much effort.

can you pls doc and (extend) test?
also it is probably better to have "getRequiredParams" and return a parset?
(as you can easily get the ids from that)

@berndbischl berndbischl changed the title export export getRequiredParams Jan 6, 2017
@berndbischl
Copy link
Member Author

looks like we have this in PR #159?

@jakob-r jakob-r added this to the v1.12 milestone Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
4 participants
@berndbischl @coveralls @ja-thomas @jakob-r