Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.8.1 #170

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
Package: mlr3filters
Title: Filter Based Feature Selection for 'mlr3'
Version: 0.8.0.9000
Version: 0.8.1
Authors@R: c(
person("Marc", "Becker", , "[email protected]", role = c("cre", "aut"),
comment = c(ORCID = "0000-0002-8115-0400")),
person("Patrick", "Schratz", , "[email protected]", role = "aut",
comment = c(ORCID = "0000-0003-0748-6624")),
person("Michel", "Lang", , "[email protected]", role = c("cre", "aut"),
person("Michel", "Lang", , "[email protected]", role = "aut",
comment = c(ORCID = "0000-0001-9754-0393")),
person("Bernd", "Bischl", , "[email protected]", role = "aut",
comment = c(ORCID = "0000-0001-6002-6980")),
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# mlr3filters (development version)
# mlr3filters 0.8.1

* compatibility: mlr3 0.22.0

Expand Down
2 changes: 1 addition & 1 deletion R/Filter.R
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Filter = R6Class("Filter",
#' Can be set to the scalar value `NA` to allow any task type.
#'
#' For a complete list of possible task types (depending on the loaded packages),
#' see [`mlr_reflections$task_types$type`][mlr_reflections].
#' see [`mlr_reflections$task_types$type`][mlr3::mlr_reflections].
task_types = NULL,

#' @field task_properties (`character()`)\cr
Expand Down
11 changes: 9 additions & 2 deletions R/FilterBoruta.R
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
#' The order of selected features is random.
#' In combination with \CRANpkg{mlr3pipelines}, only the filter criterion `cutoff` makes sense.
#'
#' @section Initial parameter values:
#' - `num.threads`:
#' - Actual default: `NULL`, triggering auto-detection of the number of CPUs.
#' - Adjusted value: 1.
#' - Reason for change: Conflicting with parallelization via \CRANpkg{future}.
#'
#' @references
#' `r format_bib("kursa_2010")`
#'
Expand Down Expand Up @@ -43,10 +49,11 @@ FilterBoruta = R6Class("FilterBoruta",
doTrace = p_int(lower = 0, upper = 4, default = 0),
holdHistory = p_lgl(default = TRUE),
getImp = p_uty(),
keep = p_fct(levels = c("confirmed", "tentative"), default = "confirmed")
keep = p_fct(levels = c("confirmed", "tentative"), default = "confirmed"),
num.threads = p_int(lower = 1, default = 1)
)

param_set$set_values(keep = "confirmed")
param_set$set_values(keep = "confirmed", num.threads = 1)

super$initialize(
id = "boruta",
Expand Down
6 changes: 3 additions & 3 deletions R/mlr_filters.R
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
#' @title Dictionary of Filters
#'
#' @format [R6Class] object
#' @format [R6::R6Class] object
#' @description
#' A simple [Dictionary] storing objects of class [Filter].
#' A simple [mlr3misc::Dictionary] storing objects of class [Filter].
#' Each Filter has an associated help page, see `mlr_filters_[id]`.
#'
#' This dictionary can get populated with additional filters by add-on packages.
#'
#' For a more convenient way to retrieve and construct filters, see [flt()].
#' @section Usage:
#'
#' See [Dictionary].
#' See [mlr3misc::Dictionary].
#'
#' @family Dictionary
#' @family Filter
Expand Down
2 changes: 1 addition & 1 deletion man/Filter.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion man/mlr3filters-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions man/mlr_filters.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions man/mlr_filters_boruta.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions tests/testthat/test_filter_regr.R
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ test_that("filters throw errors on missing values", {
})

test_that("Errors for unsupported features", {
skip_if("ames_housing" %nin% mlr_tasks$keys())
task = tsk("ames_housing")
skip_if("california_housing" %nin% mlr_tasks$keys())
task = tsk("california_housing")
filters = mlr_filters$mget(mlr_filters$keys())

# supported: numeric, integer
Expand All @@ -47,3 +47,4 @@ test_that("Errors for unsupported features", {
}
}
})

Loading