Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n-compare: Conflate anonymous sections together #30

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented Nov 20, 2024

This should resolve some of the comparison issues seen in firefox-l10n-source.

@eemeli eemeli requested a review from bcolsson November 20, 2024 13:04
Copy link
Collaborator

@bcolsson bcolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense - can you double check my understanding:

id0 = translation

## Localization Section
id1 = translation
id2 = translation

##

id3 = translation

In this case id0 and id3 would be combined because they're both anonymous sections. Or does the closing group comment create a second section?

@eemeli
Copy link
Member Author

eemeli commented Nov 20, 2024

In this case id0 and id3 would be combined because they're both anonymous sections.

Yes.

@eemeli eemeli merged commit 937e190 into main Nov 20, 2024
11 checks passed
@eemeli eemeli deleted the dedupe-empty-sections branch November 20, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants