Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack files.upload deprecated, migrate to new upload method #701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcdamo
Copy link
Contributor

@mcdamo mcdamo commented Dec 23, 2024

Slack files.upload was deprecated on May 16, 2024 and will be retired on March 11, 2025.

This change uses the new upload method as detailed here

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 49.45%. Comparing base (9d61fc5) to head (57928d0).

Files with missing lines Patch % Lines
mqttwarn/services/slack.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
- Coverage   49.75%   49.45%   -0.30%     
==========================================
  Files          81       81              
  Lines        4034     4030       -4     
==========================================
- Hits         2007     1993      -14     
- Misses       2027     2037      +10     
Flag Coverage Δ
unittests 49.45% <0.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl
Copy link
Member

amotl commented Dec 26, 2024

Hi @mcdamo, thanks a stack for your contribution. If @jpmens or @sumnerboy12 don't have any specific objections, let's merge your patch without much ado, and run another release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants