Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iroh): remove superflious info log #3080

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix(iroh): remove superflious info log #3080

merged 3 commits into from
Jan 9, 2025

Conversation

flub
Copy link
Contributor

@flub flub commented Dec 29, 2024

Description

Not every relay connection created needs to be logged on info level.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Copy link

github-actions bot commented Dec 29, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3080/docs/iroh/

Last updated: 2025-01-08T18:55:32Z

@flub
Copy link
Contributor Author

flub commented Dec 29, 2024

Upon reflection, maybe I'd like this to be an event. Not sure yet.

Copy link

github-actions bot commented Dec 29, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 40dd8f7

@dignifiedquire dignifiedquire changed the title fix(iroh): Remove superflious info log fix(iroh): remove superflious info log Jan 2, 2025
@dignifiedquire dignifiedquire added this to the v0.31.0 milestone Jan 2, 2025
@dignifiedquire
Copy link
Contributor

@flub what's the state here?

@flub
Copy link
Contributor Author

flub commented Jan 8, 2025

@flub what's the state here?

Updated, PTAL

@flub flub requested a review from dignifiedquire January 8, 2025 18:55
@flub flub added this pull request to the merge queue Jan 9, 2025
@flub flub mentioned this pull request Jan 9, 2025
Merged via the queue into main with commit 423a986 Jan 9, 2025
26 checks passed
@matheus23 matheus23 deleted the flub/less-info-logging branch January 9, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants