WIP Have relay actor remove itself from clients #3103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
created #3105 as a follow up |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
## Description Bring back `connection_id`s and ensure that client connections remove themselves from the clients list when they are done. Before, as pointed out in #3103 connections would not be cleaned up if no messages were sent to them anymore. Based on #3103 <!-- A summary of what this pull request achieves and a rough list of changes. --> ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Still WIP.
It seems to me that if a relay client actor errors almost anywhere (for example when reading from the connection to the client, which happens all the time) then that
Clientnever gets removed from theClientsunless someone else tries sending a message to that node.The
ConnectionIdthing is a pattern I've found useful for handling connection replacements. When the new connection gets put into theClientslist and then the old one gets shutdown, if we didn't check the connection id then the old connection would remove the new one from the list.Also I haven't tested these changes at all, just interested in getting thoughts on them
Breaking Changes
None?
Notes & open questions
Change checklist