Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iroh-net): add deprecation notice, bump to 0.28.2 #3116

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

flub
Copy link
Contributor

@flub flub commented Jan 10, 2025

Description

Too many users are finding this crate and trying to use it. Make it obvious where they should be looking instead.

Closes #3075.

Breaking Changes

Notes & open questions

  • This targets the new maint-0.28 branch which starts off the v0.28.1 tag.
  • Only the iroh-net crate has a new version number, I believe only publishing this crate makes the most sense.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Too many users are finding this crate and trying to use it.  Make it
obvious where they should be looking instead.
@flub flub requested a review from dignifiedquire January 10, 2025 10:00
@flub
Copy link
Contributor Author

flub commented Jan 10, 2025

I guess CI will just have to be sad?

@flub
Copy link
Contributor Author

flub commented Jan 10, 2025

cargo publish -p iroh-net --dry-run works on this branch.

@matheus23
Copy link
Contributor

Should we perhaps put a deprecation on ... all of the API? So if they use it, their editor tells them to use the new crate?

I tested a basic

#![deprecated(
    note = "this crate has been renamed from 'iroh-net' to 'iroh', please use that crate instead"
)]

in iroh-net/src/lib.rs. Seems to work.

@flub
Copy link
Contributor Author

flub commented Jan 10, 2025

Should we perhaps put a deprecation on ... all of the API? So if they use it, their editor tells them to use the new crate?

I think that's a bit harsh. There is nothing wrong with this crate and there are legitimate reasons why someone might not have upgraded yet.

@matheus23
Copy link
Contributor

Well, to be fair, people would only see that when the install the latest version of iroh-net, not if they just keep depending on 0.28.1, which wouldn't have these deprecation warnings.

I now get build errors in iroh-gossip, with or without these
deprecations.  Not sure what that is going on.
@matheus23
Copy link
Contributor

@flub can we merge this? And can we get someone who has release rights (@dignifiedquire @ramfox ?) to cut a release?

@flub
Copy link
Contributor Author

flub commented Jan 20, 2025 via email

@flub
Copy link
Contributor Author

flub commented Jan 22, 2025

Ok, ran tests, built the docs, did a publish dry-run and all is fine and dandy. I did all this with just -p iroh-net not for all crates. So I'm going to merge this.

@flub flub merged commit 31b270d into maint-0.28 Jan 22, 2025
6 of 26 checks passed
@flub flub deleted the flub/deprecate-iroh-net branch January 22, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants