-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iroh-net): add deprecation notice, bump to 0.28.2 #3116
Conversation
Too many users are finding this crate and trying to use it. Make it obvious where they should be looking instead.
I guess CI will just have to be sad? |
|
Should we perhaps put a deprecation on ... all of the API? So if they use it, their editor tells them to use the new crate? I tested a basic #![deprecated(
note = "this crate has been renamed from 'iroh-net' to 'iroh', please use that crate instead"
)] in |
I think that's a bit harsh. There is nothing wrong with this crate and there are legitimate reasons why someone might not have upgraded yet. |
Well, to be fair, people would only see that when the install the latest version of |
I now get build errors in iroh-gossip, with or without these deprecations. Not sure what that is going on.
@flub can we merge this? And can we get someone who has release rights (@dignifiedquire @ramfox ?) to cut a release? |
Does it work though? The adding of deprecations had all sorts of weird errors that I didn't dig into, so I'm not sure this is actually releasable as-is.
…On Mon, 20 Jan 2025, at 13:37, Philipp Krüger wrote:
@flub <https://github.com/flub> can we merge this? And can we get someone who has release rights ***@***.*** <https://github.com/dignifiedquire> @ramfox <https://github.com/ramfox> ?) to cut a release?
—
Reply to this email directly, view it on GitHub <#3116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABD2IB5PC63HS5PJQZXD3T2LTUXDAVCNFSM6AAAAABU6AMR5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBSGMYTONZTGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Ok, ran tests, built the docs, did a publish dry-run and all is fine and dandy. I did all this with just |
Description
Too many users are finding this crate and trying to use it. Make it obvious where they should be looking instead.
Closes #3075.
Breaking Changes
Notes & open questions
maint-0.28
branch which starts off thev0.28.1
tag.Change checklist