Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new project syncing setup #3136

Merged
merged 5 commits into from
Jan 22, 2025
Merged

chore: new project syncing setup #3136

merged 5 commits into from
Jan 22, 2025

Conversation

Arqu
Copy link
Collaborator

@Arqu Arqu commented Jan 17, 2025

Description

Revamps how we track PRs and Issues to add onto repos. Mainly because this produced issues with forks but also did all the work attribution to me.

The downside of this approach is that it runs on a schedule (set to every 6 hours but we can change). Also if GH api craps out on us we have to wait till the next trigger.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Arqu Arqu requested review from dignifiedquire and ramfox January 17, 2025 13:25
@Arqu Arqu self-assigned this Jan 17, 2025

on:
schedule:
- cron: '0 0,6,12,18 * * *'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a different schedule?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add manually triggering so that you're not entirely stuck.

But also, maybe every 1h? Or are there rate limits we need to worry about?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with every hour unless there are rate limits.

And also, if possible a manual trigger.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rate limits are per hour anyways but are also fairly generous with the Github App setup, should be fine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also will add manual triggering.

- cron: '0 0,6,12,18 * * *'

env:
REPOS_LIST: "iroh-doctor-server quinn"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to list out all the repos we're interested in. @ramfox unless you have specifics I'll just either add a very long list we used for the last iteration or try to just do all of them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ones we did for the last iteration should be right!

Copy link

github-actions bot commented Jan 17, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3136/docs/iroh/

Last updated: 2025-01-22T11:45:55Z

@Arqu Arqu added the ci continous integration label Jan 17, 2025

on:
schedule:
- cron: '0 0,6,12,18 * * *'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add manually triggering so that you're not entirely stuck.

But also, maybe every 1h? Or are there rate limits we need to worry about?

Copy link

github-actions bot commented Jan 17, 2025

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 8b40568

@Arqu Arqu enabled auto-merge January 22, 2025 11:44
@Arqu Arqu added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 96e6220 Jan 22, 2025
26 checks passed
@Arqu Arqu deleted the arqu/project_sync branch January 22, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci continous integration
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants