Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint: use modern range syntax for media query range #3523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JulianNymark
Copy link
Contributor

@JulianNymark JulianNymark commented Jan 23, 2025

Description

internal tooling, developer QoL

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: a61fbb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JulianNymark JulianNymark changed the title stylelint rule + run fixer stylelint: use modern range syntax for media query range Jan 23, 2025
Copy link
Contributor

Storybook demo / Chromatic

📝 Changes to review: 2

a442cffeb | 91 components | 135 stories

@JulianNymark JulianNymark changed the title stylelint: use modern range syntax for media query range Stylelint: use modern range syntax for media query range Jan 23, 2025
Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be some risk associated with updating the old components. For now we are transpiling it to the old syntax in the new code, but can't do this for the old code so need to keep that as is i think.
https://caniuse.com/?search=media%20range%20syntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants