refactor: add helper function for verifier tests #12771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `verify_validate_and_charge_transaction` function for verifier tests which combines `validate_transaction` and `verify_and_charge_transaction` functions. This reduces complexity of current and future tests.
miloserdow
added
A-testing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12771 +/- ##
==========================================
+ Coverage 70.51% 70.53% +0.01%
==========================================
Files 846 846
Lines 174633 174623 -10
Branches 174633 174623 -10
==========================================
+ Hits 123144 123163 +19
+ Misses 46261 46232 -29
Partials 5228 5228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nagisa
approved these changes
Jan 22, 2025
| @@ -796,6 +796,31 @@ mod tests { | |||
| } | |||
| } | |||
|
|
|||
| pub fn verify_validate_and_charge_transaction( | |||
There was a problem hiding this comment.
Suggested change
| pub fn verify_validate_and_charge_transaction( | |
| pub fn validate_verify_and_charge_transaction( |
As the functions are correspondingly validate_transaction and verify_and_charge_transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
verify_validate_and_charge_transactionfunction for verifier tests which combinesvalidate_transactionandverify_and_charge_transactionfunctions. This reduces complexity of current and future tests.