Next.js + Tailwind CSSで開発出来るようにProject構成を変更 #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
=> Failed to build the preview
Error: Cannot find module 'ajv/dist/compile/codegen'
Require stack:
- ./node_modules/ajv-keywords/dist/definitions/typeof.js
- ./node_modules/ajv-keywords/dist/keywords/typeof.js
- ./node_modules/ajv-keywords/dist/keywords/index.js
- ./node_modules/ajv-keywords/dist/index.js
- ./node_modules/schema-utils/dist/validate.js
- ./node_modules/schema-utils/dist/index.js
- ./node_modules/webpack-dev-middleware/dist/index.js
- ./node_modules/@storybook/builder-webpack5/dist/index.js
- ./node_modules/@storybook/nextjs/dist/preset.js
- ./node_modules/@storybook/core/dist/common/index.cjs
- ./node_modules/@storybook/core/dist/telemetry/index.cjs
- ./node_modules/storybook/dist/generate.cjs
- ./node_modules/storybook/bin/index.cjs
at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
at Module._resolveFilename (./node_modules/esbuild-register/dist/node.js:4794:36)
at <anonymous> (./node_modules/next/src/server/require-hook.ts:51:34)
at Module._load (node:internal/modules/cjs/loader:985:27)
at Module.require (node:internal/modules/cjs/loader:1235:19)
at Module.mod.require (./node_modules/next/src/server/require-hook.ts:70:26)
at require (node:internal/modules/helpers:176:18)
at Object.<anonymous> (./node_modules/ajv-keywords/src/definitions/typeof.ts:2:1)
at Module._compile (node:internal/modules/cjs/loader:1376:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
```
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/epic36/design-renewal-2024 #340 +/- ##
=======================================================================
- Coverage 30.49% 14.86% -15.63%
=======================================================================
Files 262 47 -215
Lines 6746 1164 -5582
Branches 354 71 -283
=======================================================================
- Hits 2057 173 -1884
+ Misses 4535 952 -3583
+ Partials 154 39 -115 ☔ View full report in Codecov by Sentry. |
keitakn
merged commit 65302bc
into
release/epic36/design-renewal-2024
7 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#337
関連 URL
https://lgtm-cat-frontend-git-feature-issue337reset-project-nekochans.vercel.app/
このPRで対応すること / このPRで対応しないこと
Tailwind CSS + Next.jsで開発が出来るようにProject構成を変更する。
Storybook の URL もしくはスクリーンショット
https://622b6c5dc31e9e003a111eb5-kejprogtks.chromatic.com/
変更点概要
タイトルの通りNext.js + Tailwind CSSで開発出来るようにProject構成を変更 している。
一旦差分が分かりやすいように新しいProjectに必要なファイルだけ残しているが、残りの機能の関しても必要な物は順次
mainブランチから移行していく。以前までの構造だと各ディレクトリに
index.tsを置くスタイル（バレルファイルというらしい）を採用していたが今回からバレルファイルは使わない構成としている。理由は下記の通りで以外とBuild時のパフォーマンスに影響を与えるようだ。
https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-7/
レビュアーに重点的にチェックして欲しい点
特になし
補足情報
特になし