-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
共通利用するButtonComponentを実装 #342
Merged
keitakn
merged 11 commits into
release/epic36/design-renewal-2024
from
feature/issue303/button-component
Aug 23, 2024
Merged
共通利用するButtonComponentを実装 #342
keitakn
merged 11 commits into
release/epic36/design-renewal-2024
from
feature/issue303/button-component
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/epic36/design-renewal-2024 #342 +/- ##
======================================================================
- Coverage 14.86% 13.02% -1.84%
======================================================================
Files 47 49 +2
Lines 1164 1328 +164
Branches 71 73 +2
======================================================================
Hits 173 173
- Misses 952 1114 +162
- Partials 39 41 +2 ☔ View full report in Codecov by Sentry. |
keitakn
merged commit Aug 23, 2024
5e35f8e
into
release/epic36/design-renewal-2024
7 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#303
関連 URL
StorybookでComponentを作成しただけなのでなし。
このPRで対応すること / このPRで対応しないこと
#303 の完了の定義を満たしている事。
Storybook の URL もしくはスクリーンショット
https://622b6c5dc31e9e003a111eb5-uqdzpgolqf.chromatic.com/?path=/story/app-components-iconbutton--with-github-icon
変更点概要
Button用の共通Componentを定義。
ただしアップロード用のボタンに関しては今回作成していない。
詳しくは以下を参照。
This pull request includes several changes focused on refactoring button components, updating dependencies, and extending the theme configuration. The most important changes include the removal of the
Button
component and its stories, the introduction of theIconButton
andLinkButton
components with their respective stories, and the extension of the Tailwind CSS configuration to include a new font family.Changes to button components:
src/app/_components/Button.tsx
: Removed theButton
component and its associated logic.src/app/_components/Button.stories.tsx
: Removed the stories for theButton
component.src/app/_components/IconButton.tsx
: Added theIconButton
component with various icon options and state handling.src/app/_components/IconButton.stories.tsx
: Added stories for theIconButton
component showcasing different icon states.src/app/_components/LinkButton.tsx
: Added theLinkButton
component for navigation purposes.src/app/_components/LinkButton.stories.tsx
: Added stories for theLinkButton
component with different styles and classes.Dependency updates:
package.json
: Removed thereact-icons
dependency.Theme configuration:
tailwind.config.ts
: Extended the Tailwind CSS configuration to include theInter
font family.レビュアーに重点的にチェックして欲しい点
特になし
補足情報
特になし