Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新デザイン(2024年)のFooterComponentを作成 #345

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Aug 23, 2024

issueURL

#323

関連 URL

StorybookでComponentを作成しただけなのでなし。

このPRで対応すること / このPRで対応しないこと

Footer用のComponentを実装する。

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-ujshxglbjj.chromatic.com/?path=/story/app-components-footer--show-japanese

変更点概要

FooterComponentを作成。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

@keitakn keitakn self-assigned this Aug 23, 2024
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2024 10:49am

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0.90090% with 110 lines in your changes missing coverage. Please review.

Project coverage is 12.09%. Comparing base (5e35f8e) to head (a3f8fc7).
Report is 4 commits behind head on release/epic36/design-renewal-2024.

Files Patch % Lines
src/app/_components/Footer.tsx 0.00% 28 Missing and 1 partial ⚠️
src/features/externalTransmissionPolicy.ts 0.00% 23 Missing and 1 partial ⚠️
src/features/privacyPolicy.ts 0.00% 19 Missing and 1 partial ⚠️
src/features/termsOfUse.ts 0.00% 19 Missing and 1 partial ⚠️
src/app/_components/Footer.stories.tsx 0.00% 15 Missing and 1 partial ⚠️
src/features/linkAttribute.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           release/epic36/design-renewal-2024     #345      +/-   ##
======================================================================
- Coverage                               13.02%   12.09%   -0.94%     
======================================================================
  Files                                      49       55       +6     
  Lines                                    1328     1439     +111     
  Branches                                   73       79       +6     
======================================================================
+ Hits                                      173      174       +1     
- Misses                                   1114     1219     +105     
- Partials                                   41       46       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keitakn keitakn marked this pull request as ready for review August 24, 2024 10:55
@keitakn keitakn merged commit 8e00fcb into release/epic36/design-renewal-2024 Aug 24, 2024
7 of 9 checks passed
@keitakn keitakn deleted the feature/issue323/add-footer-component branch August 24, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant