Skip to content

Commit

Permalink
Only churn rows once in test_scrubber_physical_gc_ancestors (#10481)
Browse files Browse the repository at this point in the history
## Problem

PR #10457 was supposed to fix the flakiness of
`test_scrubber_physical_gc_ancestors`, but instead it made it even more
flaky. However, the original error causes disappeared, now to be
replaced by key not found errors.

See this for a longer explanation:
#10391 (comment)

## Solution

This does one churn rows after all compactions, and before we do any
timeline gc's. That way, we remain more accessible at older lsn's.
  • Loading branch information
arpad-m authored Jan 22, 2025
1 parent c60b913 commit 0af40b5
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions test_runner/regress/test_storage_scrubber.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,14 @@ def test_scrubber_physical_gc_ancestors(neon_env_builder: NeonEnvBuilder, shard_
ps.http_client().timeline_compact(
shard, timeline_id, force_image_layer_creation=True, wait_until_uploaded=True
)
# Add some WAL so that we don't gc at the latest remote consistent lsn
workload.churn_rows(1)

# Add some WAL so that we don't gc at the latest remote consistent lsn
workload.churn_rows(10)

# Now gc the old stuff away
for shard in shards:
ps = env.get_tenant_pageserver(shard)
assert ps is not None
ps.http_client().timeline_gc(shard, timeline_id, 0)

# We will use a min_age_secs=1 threshold for deletion, let it pass
Expand Down

1 comment on commit 0af40b5

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7521 tests run: 7124 passed, 0 failed, 397 skipped (full report)


Flaky tests (6)

Postgres 17

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 33.5% (8492 of 25340 functions)
  • lines: 49.3% (71382 of 144704 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0af40b5 at 2025-01-22T22:08:56.756Z :recycle:

Please sign in to comment.