filter-repo: Accept multiline git config values #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some git config options can contain multiline values, for example aliases. With the current simple split on = this fails with a stacktrace so that git-filter-repo is unusable. This patch uses a multiline regular expression to split the git config --list string at any beginning line followed by an alphanumeric name with '-' and '.' followed by '='. In some cases this can falsely identify multiline values as a new variable name that does not exist. But it should work for most usual multiline config options correctly. Signed-off-by: Markus Schneider-Pargmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some git config options can contain multiline values, for example aliases. With the current simple split on = this fails with a stacktrace so that git-filter-repo is unusable.
This patch uses a multiline regular expression to split the git config --list string at any beginning line followed by an alphanumeric name with '-' and '.' followed by '='. In some cases this can falsely identify multiline values as a new variable name that does not exist. But it should work for most usual multiline config options correctly.
Corresponding bugreport #603