Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new in Qt6.8 windows fluent style #7416

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

use new in Qt6.8 windows fluent style #7416

wants to merge 4 commits into from
+23 −18

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien
Copy link
Collaborator Author

image

@mgallien
Copy link
Collaborator Author

image
on windows 11 with dark mode

@claucambra claucambra added this to the 3.14.4 milestone Oct 28, 2024
@claucambra claucambra force-pushed the feature/windowsQmlStyleFluent branch from df467f7 to 72c7217 Compare October 28, 2024 06:29
@mgallien mgallien force-pushed the feature/windowsQmlStyleFluent branch from 72c7217 to 07daf46 Compare October 31, 2024 13:10
@claucambra claucambra force-pushed the feature/windowsQmlStyleFluent branch from 07daf46 to 96eb414 Compare November 3, 2024 01:23
@claucambra claucambra modified the milestones: 3.14.4, 3.14.5 Nov 3, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

claucambra
claucambra requested changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check for the Qt version being at least 6.8

@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
@claucambra claucambra modified the milestones: 3.15.0, 3.16.0 Nov 18, 2024
@nextcloud nextcloud deleted a comment from claucambra Nov 29, 2024
@mgallien mgallien force-pushed the feature/windowsQmlStyleFluent branch from 96eb414 to e9e639b Compare December 3, 2024 17:09
@mgallien
Copy link
Collaborator Author

mgallien commented Dec 4, 2024

for people wanting to test, here is a build of this branch https://cloud.nextcloud.com/s/oT8mypQmQn9gPDc
keep it for testing only please

@mgallien
Copy link
Collaborator Author

mgallien commented Dec 4, 2024

there are a couple of small issues
see
image

@mgallien mgallien force-pushed the feature/windowsQmlStyleFluent branch 2 times, most recently from 3fa9632 to 1964dd5 Compare December 20, 2024 15:36
@Rello
Copy link
Contributor

Rello commented Jan 2, 2025

@nilsding

@Rello Rello requested a review from nilsding January 2, 2025 09:10
@nilsding nilsding force-pushed the feature/windowsQmlStyleFluent branch from 795c739 to a47f18f Compare January 3, 2025 10:27
@nilsding
Copy link
Member

nilsding commented Jan 3, 2025

@mgallien the transparency in light mode is gone now:

Screenshot_20250103_111247

I also tried to make the background have some extra blur (like you'd see in the background of the start menu), but I couldn't get it to work right with the Rectangle border :/ maybe something to revisit later.

@mgallien mgallien mentioned this pull request Jan 10, 2025
Open
@mgallien mgallien force-pushed the feature/windowsQmlStyleFluent branch from a47f18f to e8dbb74 Compare January 15, 2025 08:30
mgallien and others added 4 commits January 15, 2025 12:49
@mgallien
use new in Qt6.8 windows fluent style
7c76f5a 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
require Qt 6.8.0
0e1af57 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
switch drone ci to Qt 6.8.0 based images
887b642 
Signed-off-by: Matthieu Gallien <[email protected]>
@nilsding @mgallien
Remove transparency value from system colours where needed
ed557f6 
For some reason Windows11 has some transparency in the system colours
which makes reading drawers difficult

Signed-off-by: Jyrki Gadinger <[email protected]>
@mgallien mgallien force-pushed the feature/windowsQmlStyleFluent branch from e8dbb74 to ed557f6 Compare January 15, 2025 11:51
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7416-ed557f633aa3b9a2b4868c895cc58c18d7f16c33-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra requested changes

@nilsding nilsding nilsding approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Requested changes must be addressed to merge this pull request.

Assignees

@nilsding nilsding

Labels
os: 🚪 Windows
Projects
💻 Desktop Clients team
Status: 🏗️ In progress
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mgallien @Rello @nilsding @nextcloud-desktop-bot @claucambra