Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid detecting permissions to be invalid on linux NTFS file system #7745

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mgallien
Copy link
Collaborator

Close #7613

NTFS file system on Linux reports wrong permissions

client believes they need to be fixed but as they cannot, we end-up
having an infinite loop

Signed-off-by: Matthieu Gallien <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7745-c67aa8dde2ed198018cf3d41e91f9739fc2cf222-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots
87 New Code Smells (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
2 New Bugs (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

#if defined Q_OS_LINUX
const auto fileSystemInfo = QStorageInfo{_localPath};
qCInfo(lcEngine()) << "File system type for current sync folder:" << fileSystemInfo.fileSystemType();
if (fileSystemInfo.fileSystemType() == "NTFS") {
Copy link

@mbiebl mbiebl Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting

2025-01-10 15:44:55:888 [ info nextcloud.sync.engine /drone/src/src/libsync/syncengine.cpp:645 ]:↦      File system type for current sync folder: "fuseblk"
michael@mars:~$ findmnt /mnt/data 
TARGET    SOURCE          FSTYPE  OPTIONS
/mnt/data /dev/nvme0n1p11 fuseblk rw,relatime,user_id=0,group_id=0,allow_other,blksize=4096
michael@mars:~$ grep data /etc/fstab 
LABEL=Data      /mnt/data       ntfs-3g auto            0       0

@Rello Rello added this to the 3.16.0 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants