Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix linting getting skipped #7043

Merged
merged 23 commits into from
Nov 21, 2024
Merged

ci: Fix linting getting skipped #7043

merged 23 commits into from
Nov 21, 2024

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Nov 20, 2024

Ran into with #7033

This one has two things going on

  • Linting is getting skipped
  • Clean up fix for self-hosted runners

@edmundmiller edmundmiller self-assigned this Nov 20, 2024
.github/workflows/nf-test.yml Outdated Show resolved Hide resolved
.github/workflows/nf-test.yml Outdated Show resolved Hide resolved
@edmundmiller edmundmiller force-pushed the fix-ci-linting branch 2 times, most recently from 99822f7 to 7e6c736 Compare November 20, 2024 18:41
@edmundmiller
Copy link
Contributor Author

That's as far as I'm getting. Hopefully the runners recover over night 🫠

@edmundmiller edmundmiller marked this pull request as ready for review November 21, 2024 03:19
@edmundmiller edmundmiller requested a review from a team as a code owner November 21, 2024 03:19
@edmundmiller edmundmiller merged commit ece675b into master Nov 21, 2024
27 checks passed
@edmundmiller edmundmiller deleted the fix-ci-linting branch November 21, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants