-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add token path to Agent config Command block #958
base: v3
Are you sure you want to change the base?
Conversation
} | ||
} | ||
|
||
func Test_getTransportCredentials(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if the struct array is needed since there is only one test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really needed, but I was going to leave it there in case of expansion in the future.
* modify alpine package name: nginx-agent-3.0.0_1234 -> nginx-agent-3.0.0.1234 * protoc-gen update
* update config defaults and format
Proposed changes
Allow the data plane key to be loaded from a file by adding a new configuration option
token-path
under the Command section of the agent config file. Also refactored some code to create new functionsaddTransportCredentials
andvalidateTokenFile
which are used when creating the gRPC credentials.token
andtoken-path
are set:token-path
will take prioritytoken
field will be used as a fallback when thetoken-path
file does not exist or is inaccessibleChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)