-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx-dev): generate migration detail pages #29580
Open
isaacplmann
wants to merge
4
commits into
master
Choose a base branch
from
docs/migration-details
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacplmann
requested review from
FrozenPandaz,
jaysoo,
AgentEnder,
a team and
Coly010
as code owners
January 10, 2025 13:34
View your CI Pipeline Execution ↗ for commit 05e8d38.
☁️ Nx Cloud last updated this comment at |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
reviewed
Jan 10, 2025
@isaacplmann do we plan to render the requirements some migrations have? I think it would make sense to do so as it adds clarity about why some migrations might run or not. Examples of those requirements:
|
Coly010
approved these changes
Jan 14, 2025
jaysoo
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates migration detail pages for every migration
To add sample code changes for a migration that has an implementation file, create a
.md
file with the same name as the implementation file in the same folder as the implementation file. i.e.move-cache-directory.md
formove-cache-directory.ts
.Migrations that have
packages
defined will have a table generated with the package updates listed.Separate PRs will be created to add sample code changes for each migration with an implementation.
The migration list on the plugin overview page: Angular migrations
Sample migration with added markdown file details: 17.0.0-move-cache-directory
Sample migration with only package updates: Angular 16.4.0
Sample migration without any markdown file details: 17.0.0-use-minimal-config-for-tasks-runner-options