-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(locale): remove emoji fallback for Chinese #3134
base: v3
Are you sure you want to change the base?
Conversation
commit: |
@BlackWhite2000 @ChiahongHong Would you mind reviewing this as it introduces a breaking change? |
LGTM. My previous wording adjustments #3051 were tailored for Taiwan, which has the largest number of Traditional Chinese users. However, Hong Kong and Macau also use Traditional Chinese. This change will make it easier to add localization for those regions in the future. It is also aligned with the naming conventions of other files. |
Actually, Iโve considered this before, and thereโs one thing Iโd like to ask. In the documents Iโve reviewed, most of the time, thereโs only a distinction between Simplified and Traditional Chinese, and I often donโt focus on the specific differences in variants. Therefore, in most cases, I tend to use the more general zh_hans and zh_hant. For Traditional Chinese users, would there be issues with reading variants? This is the part Iโm unsure about, because in many cases, the text is the same. I wonder if making too many distinctions might lead to repetitive work for translators. |
I believe you're touching on the distinction between translation and localization. The issue might not be about whether itโs understandable, but rather about familiarity with the wording/terminology. I understand your concerns, but I would lean toward this approach. It leaves room for future localization adjustments if significant regional differences in terminology arise. The efforts required from translators should not be substantial, as they would only need to adjust the differing terms from the existing translations. |
I've thought about it carefully, and previously I approached it from the perspective of translation. However, if we look at it from a localization standpoint, dividing by regions would indeed make more sense. |
Yes! I believe that any native Chinese user has an โinternal converterโ for Traditional and Simplified Chinese characters, allowing us to deduce the meaning of characters based on context. That said, for me, I can read Simplified Chinese but canโt really write it ๐ Thank you for your kind concern! Most of our areas are doing well. |
๐ Linked issue
โ Type of change
๐ Description
This PR addresses the problem that maps all Chinese variants (
zh-*
) into ๐จ๐ณ in the supported language section. The change respects each variants' major user countries while remaining flexibility for other variants likezh-HK
, i.e. Traditional Chinese (Hong Kong).Also, I wonder if docs/server/api/locales.json.get.ts is unnecessary and can be removed as the emoji is determined from
code
property in each locale configuration.๐ Checklist