Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handler to list rules for all tenants #6

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Add handler to list rules for all tenants #6

merged 5 commits into from
Jan 19, 2022

Conversation

onprem
Copy link
Member

@onprem onprem commented Jan 5, 2022

This PR adds a handler for the listAllRules endpoint recently added in the spec.

Signed-off-by: Prem Saraswat [email protected]

@onprem onprem mentioned this pull request Jan 5, 2022
Merged
bill3tt
bill3tt approved these changes Jan 6, 2022
View reviewed changes
Copy link

@bill3tt bill3tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Had a good look through and can't see anything to complain about 😅

squat
squat reviewed Jan 6, 2022
View reviewed changes
pkg/server/server.go Outdated Show resolved Hide resolved
squat
squat reviewed Jan 6, 2022
View reviewed changes
pkg/server/server.go Outdated Show resolved Hide resolved
@onprem onprem requested a review from squat January 10, 2022 14:44
matej-g
matej-g approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎉

pkg/server/server.go Outdated Show resolved Hide resolved
pkg/server/server.go Show resolved Hide resolved
@matej-g matej-g merged commit 8650540 into observatorium:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej-g matej-g matej-g approved these changes

@bill3tt bill3tt bill3tt approved these changes

@squat squat Awaiting requested review from squat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onprem @squat @bill3tt @matej-g