Merge pull request #23 from varad-ahirwadkar/rsct-image

Allow RSCT image to configure runtime via the RSCT spec
ocp-power-automation · Jul 18, 2024 · 1b3e7af · 1b3e7af
2 parents 432cbbd + ab32ea3
commit 1b3e7af
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 12 deletions.
diff --git a/api/v1alpha1/rsct_types.go b/api/v1alpha1/rsct_types.go
@@ -28,8 +28,10 @@ type RSCTSpec struct {
 	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
 	// Important: Run "make" to regenerate code after modifying this file
 
-	// Foo is an example field of RSCT. Edit rsct_types.go to remove/update
-	Foo string `json:"foo,omitempty"`
+	// Image is an RSCT image
+	// +kubebuilder:default="quay.io/powercloud/rsct-ppc64le:latest"
+	// +optional
+	Image *string `json:"image,omitempty"`
 }
 
 // RSCTStatus defines the observed state of RSCT

diff --git a/api/v1alpha1/zz_generated.deepcopy.go b/api/v1alpha1/zz_generated.deepcopy.go
diff --git a/bundle/manifests/rsct.ibm.com_rscts.yaml b/bundle/manifests/rsct.ibm.com_rscts.yaml
@@ -39,9 +39,9 @@ spec:
           spec:
             description: RSCTSpec defines the desired state of RSCT
             properties:
-              foo:
-                description: Foo is an example field of RSCT. Edit rsct_types.go to
-                  remove/update
+              image:
+                default: quay.io/powercloud/rsct-ppc64le:latest
+                description: Image is an RSCT image
                 type: string
             type: object
           status:

diff --git a/config/crd/bases/rsct.ibm.com_rscts.yaml b/config/crd/bases/rsct.ibm.com_rscts.yaml
@@ -39,9 +39,9 @@ spec:
           spec:
             description: RSCTSpec defines the desired state of RSCT
             properties:
-              foo:
-                description: Foo is an example field of RSCT. Edit rsct_types.go to
-                  remove/update
+              image:
+                default: quay.io/powercloud/rsct-ppc64le:latest
+                description: Image is an RSCT image
                 type: string
             type: object
           status:

diff --git a/internal/controller/daemonset.go b/internal/controller/daemonset.go
@@ -37,7 +37,6 @@ const (
 	osID                = "rhcos"
 	rmcPort             = 657
 	rmcAppName          = "powervm-rmc"
-	rsctImage           = "quay.io/powercloud/rsct-ppc64le:latest"
 )
 
 type DaemonSetConfig struct {

diff --git a/internal/controller/rsct_controller.go b/internal/controller/rsct_controller.go
@@ -71,10 +71,12 @@ func (r *RSCTReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
 		return reconcile.Result{}, fmt.Errorf("failed to get RSCT %s: %w", req, err)
 	}
 
-	// TODO(mjturek): Allow image specification
 	r.Config.Namespace = rsct.Namespace
 	r.Config.Name = rsct.Name
-	r.Config.Image = "quay.io/powercloud/rsct-ppc64le:latest"
+	// Set default RSCT image if not specified
+	if rsct.Spec.Image != nil {
+		r.Config.Image = *rsct.Spec.Image
+	}
 
 	haveServiceAccount, sa, err := r.ensureRSCTServiceAccount(ctx, rsct)
 	if err != nil {