Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all the valid semantic version tags #24

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add all the valid semantic version tags #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-operator-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Build and Publish RSCT Operator
on:
push:
tags:
- '[0-9]+.[0-9]+.[0-9]+'
- 'v*.*.*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Operator SDK does not support the 'v' character in version numbers; therefore, used versions without 'v'. To address this, we can modify -

rsct-operator/.github/workflows/build-operator-images.yml

Line 19 in a00303e

run: echo "VERSION=$(echo ${GITHUB_REF/refs\/tags\//})" >> $GITHUB_ENV
this to

echo "VERSION=$(echo ${GITHUB_REF/refs\/tags\/v/})" >> $GITHUB_ENV

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, lemme do that then..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done that change, ptal to the latest codechange

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm


env:
GO_VERSION: "1.22"
Expand All @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Set the release version
run: echo "VERSION=$(echo ${GITHUB_REF/refs\/tags\//})" >> $GITHUB_ENV
run: echo "VERSION=$(echo ${GITHUB_REF/refs\/tags\/v/})" >> $GITHUB_ENV

- name: Checkout
uses: actions/checkout@v4
Expand Down