Bump version to 1.3.4 #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Version 1.4.0 would also be fine and possibly better reflect the amount of changes. But I am not sure if we should go here for a version 2, because there is also ocropus2 and ocropus3 which could lead to confusions. Let us maybe freeze the 1 and just count on the second place higher and higher. Thus, your python3-compatible commit should lead to version 1.5.0. What do you think? |
|
I had the same thought (ocropus2 and ocropy 2.0.0) but reasoned the changes in API (imageio, numpy etc) merited the major bump. But it really does not matter that much I think, minor bump is fine too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to release a new release before doing anything larger like the Python3 compatibility. A draft is already prepared... This PR is then first to be merged, before releasing. Is there anything else we should look for v1.3.4? @kba