Skip to content
build-refactor

feat: add ability to trace handshake #60

Sign in to view logs

feat: add ability to trace handshake

feat: add ability to trace handshake #60

Triggered via pull request February 13, 2024 10:25
@ainghazalainghazal
synchronize #64
ainghazal:feat/handshake-trace
Status Success
Total duration 1m 23s
Artifacts –

build-refactor.yml

on: pull_request
short-tests
11s
short-tests
lint
6s
lint
gosec
35s
gosec
coverage-threshold
1m 14s
coverage-threshold
integration
29s
integration
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
lint: internal/session/manager.go#L23
comment on exported const S_UNDEF should be of the form "S_UNDEF ..."
lint: internal/session/manager.go#L17
type name will be used as session.SessionNegotiationState by other packages, and that stutters; consider calling this NegotiationState
lint: internal/session/manager.go#L231
exported var ErrExpiredKey should have comment or be unexported
lint: internal/session/manager.go#L166
comment on exported method Manager.NewACKForPacketIDs should be of the form "NewACKForPacketIDs ..."
lint: internal/bytesx/bytesx.go#L38
comment on exported function GenRandomBytes should be of the form "GenRandomBytes ..."
lint: internal/session/manager.go#L21
don't use ALL_CAPS in Go names; use CamelCase
lint: internal/bytesx/bytesx.go#L115
comment on exported function BytesPadPKCS7 should be of the form "BytesPadPKCS7 ..."
lint: internal/datachannel/errors.go#L26
exported var ErrSerialization should have comment or be unexported
lint: internal/session/manager.go#L24
don't use ALL_CAPS in Go names; use CamelCase
lint: internal/tlssession/tlsbio.go#L75
parameter 'tt' seems to be unused, consider removing or renaming it as _