Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): feature propagation checks #134

Merged
merged 9 commits into from
Jan 24, 2025

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Jan 24, 2025

Closes #21. Adds feature propagation checks, in a new file to avoid clogging up the existing jobs.

Lmk if we'd like to move this somewhere else!

Closes op-rs#21. Adds feature propagation checks, in a new file to avoid clogging up the existing jobs.

Lmk if we'd like to move this somewhere else!
Copy link
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about zepter. Nice!

Glad to try this out, cc @refcell.

@Evalir
Copy link
Contributor Author

Evalir commented Jan 24, 2025

forgot to draft this as mark btw—still need to properly config zepter.

@Evalir Evalir marked this pull request as draft January 24, 2025 16:00
@Evalir Evalir marked this pull request as ready for review January 24, 2025 16:15
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zepter good

@Evalir
Copy link
Contributor Author

Evalir commented Jan 24, 2025

zepter gud

.config/zepter.yaml Outdated Show resolved Hide resolved
@Evalir Evalir requested a review from mattsse January 24, 2025 16:31
@Evalir
Copy link
Contributor Author

Evalir commented Jan 24, 2025

Aight, this is working now and I've pushed the autofixes zepter does. do see the zepter.yaml file to see what features are getting checked rn

@refcell refcell merged commit e5fd934 into op-rs:main Jan 24, 2025
21 checks passed
@Evalir Evalir deleted the evalir/add-feat-propagation-check branch January 24, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Feature propagation check CI
4 participants