fix counters for interfaces #3683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #3683 / 201d743Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 12801703938Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
dplore
requested changes
Jan 7, 2025
| @@ -548,3 +603,39 @@ func waitOTGARPEntry(t *testing.T) { | |||
| }).Await(t) | |||
|
|
|||
| } | |||
|
|
|||
| func (tc *testCase) setupAggregateAtomically(t *testing.T) { | |||
There was a problem hiding this comment.
this should be moved to internal/cfgplugins/interface.go and represent the generate config part of the work.
In the Test function, a gnmi.Replace can use the output of the cfgplugin
There was a problem hiding this comment.
Darren, actually these functions are not used in this test, will remove it from here.
…ate, not used in this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below changes are to address gaps in verifying counters on the device