-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [curve/toos-v2] add list chunkserver #2386
Conversation
good job, feel free to communicate if you have any questions |
@Cyber-SiKu plz have a look
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended to split into two pr:
check-chunkserver and list-chunkserver
d61973b
to
bc56358
Compare
tools-v2/pkg/cli/command/curvebs/list/chunkserver/chunkserver.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/list/chunkserver/chunkserver.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/list/chunkserver/chunkserver.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/list/chunkserver/chunkserver.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/list/chunkserver/chunkserver.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/list/chunkserver/chunkserver.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/list/chunkserver/chunkserver.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/list/chunkserver/chunkserver.go
Outdated
Show resolved
Hide resolved
Hi, I am trying to use ListChunkServer method in my job, could you please add an interface for others? like this method in the end |
+1 |
I'll done it. |
tools-v2/pkg/cli/command/curvebs/list/chunkserver/chunkserver.go
Outdated
Show resolved
Hide resolved
1da337b
to
ae30555
Compare
tools-v2/pkg/cli/command/curvebs/list/chunkserver/chunkserver.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Sindweller <[email protected]>
cicheck |
cicheck |
What problem does this PR solve?
Issue Number: #2036
Problem Summary: support list chunkserver command in curve tool
What is changed and how it works?
What's Changed: add /tools-v2/pkg/cli/command/curvebs/list/chunkserver.go
How it Works: curve bs list chunkserver
Side effects(Breaking backward compatibility? Performance regression?):
Check List