Skip to content

Commit

Permalink
Add --cgroup-manager cgroupfs for e2e PR check
Browse files Browse the repository at this point in the history
  • Loading branch information
sutaakar authored and openshift-merge-bot[bot] committed Nov 27, 2024
1 parent dd6851a commit 390fb17
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/e2e_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ jobs:
kind load image-archive cfo.tar --name cluster --verbosity 1000
make deploy -e IMG="${IMG}" -e ENV="e2e"
kubectl wait --timeout=120s --for=condition=Available=true deployment -n openshift-operators codeflare-operator-manager
env:
# cgroup-manager configuration is required for NVidia image used in e2e PR check
IMAGE_BUILD_FLAGS: '--cgroup-manager cgroupfs'

- name: Run e2e tests
run: |
Expand Down
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ endif

# Image URL to use all building/pushing image targets
IMG ?= ${IMAGE_TAG_BASE}:${VERSION}

# IMAGE_BUILD_FLAGS are the flags passed to the podman operator image build command
IMAGE_BUILD_FLAGS :=

# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.24.2

Expand Down Expand Up @@ -184,7 +188,7 @@ run: manifests fmt vet ## Run a controller from your host.

.PHONY: image-build
image-build: test-unit ## Build container image with the manager.
podman build -t ${IMG} .
podman $(IMAGE_BUILD_FLAGS) build -t ${IMG} .

.PHONY: image-push
image-push: image-build ## Push container image with the manager.
Expand Down

0 comments on commit 390fb17

Please sign in to comment.