-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration to pipeline stanza of DSC to enable InstructLab pipeline #1484
base: main
Are you sure you want to change the base?
Add configuration to pipeline stanza of DSC to enable InstructLab pipeline #1484
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c19f08f
to
4ec11e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
+ Coverage 19.69% 19.75% +0.06%
==========================================
Files 160 160
Lines 10985 11012 +27
==========================================
+ Hits 2163 2175 +12
- Misses 8594 8606 +12
- Partials 228 231 +3 ☔ View full report in Codecov by Sentry. |
controllers/components/datasciencepipelines/datasciencepipelines_controller_actions.go
Outdated
Show resolved
Hide resolved
4ec11e6
to
cb45a5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added text suggestions.
This PR can't be merged just yet 😢Please run For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12705522276 |
This PR can't be merged just yet 😢Please run For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12705547559 |
9f53127
to
bd7ab11
Compare
@@ -51,6 +52,7 @@ type DataSciencePipelinesSpec struct { | |||
|
|||
type DataSciencePipelinesCommonSpec struct { | |||
common.DevFlagsSpec `json:",inline"` | |||
PreloadedPipelines datasciencepipelines.PreloadedPipelinesSpec `json:"preloadedPipelines,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HumairAK do you think that we should change the term "preloaded" here since we will be supporting importing the pipeline on existing pipeline servers? Some ideas are builtinPipelines
, managedPipelines
, or platformPipelines
.
This PR can't be merged just yet 😢Please run For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12902820594 |
This PR can't be merged just yet 😢Please run For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12902824301 |
type PreloadedPipelinesSpec struct { | ||
// Configures whether to automatically import the InstructLab pipeline. | ||
// You must enable the trainingoperator component to run the InstructLab pipeline. | ||
InstructLab PreloadedPipelineOptions `json:"instructLab,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Giulio Frasca <[email protected]>
Co-authored-by: Matt Prahl <[email protected]>
Co-authored-by: Matt Prahl <[email protected]>
9a1789e
to
7026025
Compare
Description
This PR adds an configuration option to the
DataSciencePipelines
component configuration to enabledInstructLab
pipelines:Once configured, the
PREINSTALLEDPIPELINES
property of theDataSciencePipelines
'sparams.env
file will looks like:https://issues.redhat.com/browse/RHOAIENG-16509
How Has This Been Tested?
Screenshot or short clip
Merge criteria