Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to pipeline stanza of DSC to enable InstructLab pipeline #1484

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Jan 9, 2025

Description

This PR adds an configuration option to the DataSciencePipelines component configuration to enabled InstructLab pipelines:

apiVersion: datasciencecluster.opendatahub.io/v1
kind: DataScienceCluster
metadata:
  name: default-dsc
spec:
  components:
    codeflare:
      managementState: Removed
    dashboard:
      managementState: Removed
    datasciencepipelines:
      managementState: Managed
      preloadedPipelines:
        instructLab:
          state: Managed

Once configured, the PREINSTALLEDPIPELINES property of the DataSciencePipelines's params.env file will looks like:

➜ cat opt/manifests/datasciencepipelines/base/params.env | grep PREINSTALLEDPIPELINES   
PREINSTALLEDPIPELINES="{\"instructLab\":{\"state\":\"Removed\"}}"

https://issues.redhat.com/browse/RHOAIENG-16509

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Jan 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lburgazzoli. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lburgazzoli lburgazzoli force-pushed the RHOAIENG-16509-InstructLab branch 2 times, most recently from c19f08f to 4ec11e6 Compare January 9, 2025 12:23
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 23.07692% with 30 lines in your changes missing coverage. Please review.

Project coverage is 19.75%. Comparing base (2258161) to head (7026025).

Files with missing lines Patch % Lines
...tasciencepipelines/datasciencepipelines_support.go 45.00% 8 Missing and 3 partials ⚠️
...nents/datasciencepipelines/datasciencepipelines.go 0.00% 10 Missing ⚠️
...pelines/datasciencepipelines_controller_actions.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   19.69%   19.75%   +0.06%     
==========================================
  Files         160      160              
  Lines       10985    11012      +27     
==========================================
+ Hits         2163     2175      +12     
- Misses       8594     8606      +12     
- Partials      228      231       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lburgazzoli lburgazzoli force-pushed the RHOAIENG-16509-InstructLab branch from 4ec11e6 to cb45a5e Compare January 9, 2025 16:37
@lburgazzoli lburgazzoli requested review from HumairAK and mprahl January 9, 2025 16:38
Copy link

@aduquett aduquett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added text suggestions.

apis/components/v1alpha1/datasciencepipelines/types.go Outdated Show resolved Hide resolved
apis/components/v1alpha1/datasciencepipelines/types.go Outdated Show resolved Hide resolved
apis/components/v1alpha1/datasciencepipelines/types.go Outdated Show resolved Hide resolved
Copy link
Contributor

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12705522276

Copy link
Contributor

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12705547559

@lburgazzoli lburgazzoli force-pushed the RHOAIENG-16509-InstructLab branch from 9f53127 to bd7ab11 Compare January 10, 2025 09:04
@@ -51,6 +52,7 @@ type DataSciencePipelinesSpec struct {

type DataSciencePipelinesCommonSpec struct {
common.DevFlagsSpec `json:",inline"`
PreloadedPipelines datasciencepipelines.PreloadedPipelinesSpec `json:"preloadedPipelines,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumairAK do you think that we should change the term "preloaded" here since we will be supporting importing the pipeline on existing pipeline servers? Some ideas are builtinPipelines, managedPipelines, or platformPipelines.

Copy link
Contributor

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12902820594

Copy link
Contributor

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12902824301

type PreloadedPipelinesSpec struct {
// Configures whether to automatically import the InstructLab pipeline.
// You must enable the trainingoperator component to run the InstructLab pipeline.
InstructLab PreloadedPipelineOptions `json:"instructLab,omitempty"`
Copy link
Contributor Author

@lburgazzoli lburgazzoli Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumairAK @etirelli should we add some logic in the ODH Operator to handle this requirement ? i.e. reporting the component as misconfigured ?

@lburgazzoli lburgazzoli force-pushed the RHOAIENG-16509-InstructLab branch from 9a1789e to 7026025 Compare January 22, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

6 participants