Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify DataScienceCluster conditions #1501

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Simplify DataScienceCluster conditions

fd42704
Select commit
Loading
Failed to load commit list.
Draft

Simplify DataScienceCluster conditions #1501

Simplify DataScienceCluster conditions
fd42704
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2025 in 0s

20.74% (+0.85%) compared to 8622753

View this Pull Request on Codecov

20.74% (+0.85%) compared to 8622753

Details

Codecov Report

Attention: Patch coverage is 73.60000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 20.74%. Comparing base (8622753) to head (fd42704).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...cecluster/datasciencecluster_controller_support.go 86.86% 9 Missing and 4 partials ⚠️
...atasciencecluster/datasciencecluster_controller.go 0.00% 9 Missing ⚠️
pkg/utils/test/matchers/jq/jq_support.go 0.00% 6 Missing ⚠️
pkg/utils/test/matchers/jq/jq_transform.go 57.14% 2 Missing and 1 partial ⚠️
...lers/components/modelcontroller/modelcontroller.go 0.00% 1 Missing ⚠️
...rs/components/modelmeshserving/modelmeshserving.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
+ Coverage   19.89%   20.74%   +0.85%     
==========================================
  Files         160      161       +1     
  Lines       10824    10846      +22     
==========================================
+ Hits         2153     2250      +97     
+ Misses       8444     8364      -80     
- Partials      227      232       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov