update: add cronjob registered in operator + add into cache for template and cronjob #1510
Conversation
…n cluster Signed-off-by: Wen Zhou <[email protected]>
|
cc @TomerFi |
zdtsw
requested review from
lburgazzoli and
jstourac
and removed request for
MarianMacik and
biswassri
pkg/upgrade/upgrade.go
Outdated
| @@ -652,6 +652,10 @@ func cleanupNimIntegration(ctx context.Context, cli client.Client, oldRelease cl | |||
|
|
|||
| for _, delObj := range deleteObjs { | |||
| if gErr := cli.Get(ctx, types.NamespacedName{Name: delObj.name, Namespace: applicationNS}, delObj.obj); gErr != nil { | |||
| if errors.Is(gErr, &meta.NoKindMatchError{}) { | |||
| log.V(1).Error(k8serr.NewNotFound(schema.GroupResource{}, delObj.obj.GetName()), fmt.Sprintf("%s %s not found", delObj.desc, delObj.name)) | |||
There was a problem hiding this comment.
is this actually an error ? if neither kserve, nor modelmesh have been installed before, this would result in an error but it is not (IMHO)
There was a problem hiding this comment.
but this is a check on the CRD, not on object, right?
i think the error was complaining not seeing "Template" in the cluster.
There was a problem hiding this comment.
Yes it would signal that the kind is unknown. My point is - if this should be seen as an error or not because if the type do not exist, then also the object won't exist.
However if the Template type is not know, would the installation of the component fail ?
There was a problem hiding this comment.
However if the
Templatetype is not know, would the installation of the component fail ?
if it fails, let it fail there in the component, not on cleanup of some leftover :)
Signed-off-by: Wen Zhou <[email protected]>
… exist in cluster" This reverts commit d5dfb81.
Signed-off-by: Wen Zhou <[email protected]>
zdtsw
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
=======================================
Coverage 19.78% 19.78%
=======================================
Files 160 160
Lines 10880 10880
=======================================
Hits 2153 2153
Misses 8500 8500
Partials 227 227 ☔ View full report in Codecov by Sentry. |
|
@TomerFi: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TomerFi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria