Skip to content

Commit

Permalink
feat(chart): use system-critical priorityClass for localpv dsp-operat…
Browse files Browse the repository at this point in the history
…or and csi ctrl

Signed-off-by: Niladri Halder <[email protected]>
  • Loading branch information
niladrih committed Jan 23, 2025
1 parent c07c05c commit 0f9e0a9
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion chart/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ dependencies:
repository: https://nats-io.github.io/k8s/helm/charts/
condition: eventing.enabled
- name: localpv-provisioner
version: 4.1.2
version: 4.1.4
repository: https://openebs.github.io/dynamic-localpv-provisioner
condition: localpv-provisioner.enabled
3 changes: 2 additions & 1 deletion chart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ This removes all the Kubernetes components associated with the chart and deletes
| https://grafana.github.io/helm-charts | loki-stack | 2.9.11 |
| https://jaegertracing.github.io/helm-charts | jaeger-operator | 2.50.1 |
| https://nats-io.github.io/k8s/helm/charts/ | nats | 0.19.14 |
| https://openebs.github.io/dynamic-localpv-provisioner | localpv-provisioner | 4.1.2 |
| https://openebs.github.io/dynamic-localpv-provisioner | localpv-provisioner | 4.1.4 |

## Values

Expand Down Expand Up @@ -190,6 +190,7 @@ This removes all the Kubernetes components associated with the chart and deletes
| io_engine.&ZeroWidthSpace;tolerations | Set tolerations, overrides global | `[]` |
| localpv-provisioner.&ZeroWidthSpace;enabled | Enables the openebs dynamic-localpv-provisioner. If disabled, modify etcd and loki-stack storage class accordingly. | `true` |
| localpv-provisioner.&ZeroWidthSpace;hostpathClass.&ZeroWidthSpace;enabled | Enable default hostpath localpv StorageClass. | `false` |
| localpv-provisioner.&ZeroWidthSpace;localpv.&ZeroWidthSpace;priorityClassName | Set the PriorityClass for the LocalPV Hostpath provisioner Deployment. | `"{{ .Release.Name }}-cluster-critical"` |
| loki-stack.&ZeroWidthSpace;enabled | Enable loki log collection for our components | `true` |
| loki-stack.&ZeroWidthSpace;localpvScConfig.&ZeroWidthSpace;basePath | Host path where local etcd data is stored in. | `"/var/local/{{ .Release.Name }}/localpv-hostpath/loki"` |
| loki-stack.&ZeroWidthSpace;localpvScConfig.&ZeroWidthSpace;reclaimPolicy | ReclaimPolicy of loki's localpv hostpath storage class. | `"Delete"` |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
{{ include "label_prefix" . }}/version: {{ .Chart.Version }}
{{ include "label_prefix" . }}/logging: "true"
spec:
serviceAccount: {{ .Release.Name }}-service-account
serviceAccountName: {{ .Release.Name }}-service-account
imagePullSecrets:
{{- include "base_pull_secrets" . }}
initContainers:
Expand Down
4 changes: 2 additions & 2 deletions chart/templates/mayastor/csi/csi-controller-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ spec:
{{ include "label_prefix" . }}/logging: "true"
spec:
hostNetwork: true
serviceAccount: {{ .Release.Name }}-service-account
serviceAccountName: {{ .Release.Name }}-service-account
dnsPolicy: ClusterFirstWithHostNet
imagePullSecrets:
{{- include "base_pull_secrets" . }}
initContainers:
{{- include "jaeger_collector_init_container" . }}
{{- include "rest_agent_init_container" . }}
{{- if $pcName := include "priority_class" (dict "template" . "localPriorityClass" .Values.csi.controller.priorityClassName) }}
{{- if $pcName := include "priority_class_with_default" (dict "template" . "localPriorityClass" .Values.csi.controller.priorityClassName) }}
priorityClassName: {{ $pcName }}
{{- end }}
{{- if .Values.nodeSelector }}
Expand Down
2 changes: 1 addition & 1 deletion chart/templates/mayastor/csi/csi-node-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
{{ include "label_prefix" . }}/version: {{ .Chart.Version }}
{{ include "label_prefix" . }}/logging: "true"
spec:
serviceAccount: {{ .Release.Name }}-service-account
serviceAccountName: {{ .Release.Name }}-service-account
hostNetwork: true
dnsPolicy: ClusterFirstWithHostNet
imagePullSecrets:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ spec:
{{ include "label_prefix" . }}/version: {{ .Chart.Version }}
{{ include "label_prefix" . }}/logging: "true"
spec:
serviceAccount: {{ .Release.Name }}-service-account
serviceAccountName: {{ .Release.Name }}-service-account
imagePullSecrets:
{{- include "base_pull_secrets" . }}
initContainers:
{{- include "base_init_containers" . }}
{{- if $pcName := include "priority_class" (dict "template" . "localPriorityClass" .Values.operators.pool.priorityClassName) }}
{{- if $pcName := include "priority_class_with_default" (dict "template" . "localPriorityClass" .Values.operators.pool.priorityClassName) }}
priorityClassName: {{ $pcName }}
{{- end }}
{{- if .Values.nodeSelector }}
Expand Down
5 changes: 5 additions & 0 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -835,6 +835,11 @@ storageClass:
localpv-provisioner:
# -- Enables the openebs dynamic-localpv-provisioner. If disabled, modify etcd and loki-stack storage class accordingly.
enabled: true

localpv:
# -- Set the PriorityClass for the LocalPV Hostpath provisioner Deployment.
priorityClassName: "{{ .Release.Name }}-cluster-critical"

hostpathClass:
# -- Enable default hostpath localpv StorageClass.
enabled: false
Expand Down

0 comments on commit 0f9e0a9

Please sign in to comment.