feat(plugin): add support to fetch ns from kubeconfig context #608
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If '---ns_from_context' flag is set then we fetch ns from the kubeconfig context, otherwise, --namespace arg is used. '---ns_from_context' takes precedence over -n if both are used. Signed-off-by: Abhilash Shetty <[email protected]>
abhilashshetty04
requested review from
tiagolobocastro,
sinhaashish,
niladrih,
Abhinandan-Purkait and
dsharma-dc
| let mut args = CliArgs::parse(); | ||
| args.args.namespace = args.namespace.clone(); | ||
| args.args.namespace = if args.ns_from_context { | ||
| let client = Client::try_default().await.expect("Client init failed"); |
There was a problem hiding this comment.
hmm this is not taking into account the kubeconfig path
|
|
||
| /// Use namespace from the current `kubeconfig` context, | ||
| /// Takes precedence over --namespace or -n flag. | ||
| #[clap(global = true, long, short = 'c', default_value = "false")] |
There was a problem hiding this comment.
We should hide this, since it's not meant to be used for now IIRC
Suggested change
| #[clap(global = true, long, short = 'c', default_value = "false")] | |
| #[clap(global = true, hide = true, long = "namespace-from-context", default_value = "false")] |
There was a problem hiding this comment.
Also should make it conflict with --namespace? Both supplied at the same time doesn't make sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If '---ns_from_context' flag is set then we fetch ns from the kubeconfig context, otherwise, --namespace arg is used. '---ns_from_context' takes precedence over -n if both are used.