fix: catch a possible exception in beta course configuration #36172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the learner is a beta tester, and the beta test has been set up with a large duration, the courseware djangoapp can return an overflow error on a timedelta call. In those circumstances, this defaults to returning an unmodified date. FIXES: APER-3848
removing an unused import
deborahgu
commented
Jan 24, 2025
| @@ -93,7 +95,7 @@ def enterprise_learner_enrolled(request, user, course_key): | |||
| # enterprise_customer_data is either None (if learner is not linked to any customer) or a serialized | |||
| # EnterpriseCustomer representing the learner's active linked customer. | |||
| enterprise_customer_data = enterprise_customer_from_session_or_learner_data(request) | |||
| learner_portal_enabled = enterprise_customer_data and enterprise_customer_data['enable_learner_portal'] | |||
| learner_portal_enabled = enterprise_customer_data and enterprise_customer_data["enable_learner_portal"] | |||
There was a problem hiding this comment.
all of the changes in this file from this line down are just because I let my IDE autolint the file to our current standards. Usually I wouldn't commit an autoformat at the same time as an actual code change, but because the code change is just that one tiny block above, and the autoformat isn't extreme, it seemed like a legitimate choice. I can undo if reviewers prefer.
deborahgu
commented
Jan 24, 2025
| adjusted_date = adjust_start_date(user, days_early_for_beta, start, course_key) | ||
| self.assertEqual(expected, adjusted_date) | ||
|
|
||
|
|
There was a problem hiding this comment.
same as above – from here on down it is just autoformatting. Again, I can undo it and just put in the individual changes the reviewers think it is too excessive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when the learner is a beta tester, and the beta test has been set up with an extremely large duration, the courseware djangoapp can return an overflow error on a timedelta call. In those circumstances, this defaults to returning an unmodified date.
FIXES: APER-3848